Prevent emitting log events without listeners - #1108
Merged
Conversation
mfazekas
approved these changes
Nov 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added check before emitting
LogEventmessages viaRCTEventEmitter.On iOS each
RCTEventEmittermodule needs to track whether or not there are observers before sending events. Otherwise when events are emitted without observers a (console) warning is triggered by react-native, in this case:In practice I experienced Mapbox sending out messages after unmount causing the above warning.
Similar to https://github.com/react-native-mapbox-gl/maps/blob/f2eb9d7bb55cb3227b2ccc432de11e13246c689f/ios/RCTMGL/RCTMGLLocationModule.m#L85-L96