Support mapbox 6.0 and later and switch to $ReactNativeMapboxGLIOSVersion - #1044
Conversation
ferdicus
left a comment
There was a problem hiding this comment.
Thanks 👍
Are you also going to add some form of update into the changelog or do you think the deprecation warning is enough?
The env was in our changelog https://github.com/react-native-mapbox-gl/maps/blob/master/CHANGELOG.md#810rc2 i've added this deprecation not the that link as well. |
Cool 👏 Should we also add the |
e82a26f to
40a46cd
Compare
40a46cd to
1f44113
Compare
|
Been having a bit of trouble understanding how to approach this for this PR. Looks like it might be attempting to download the correct SDK from Mapbox but I'm unauthorized. Do we place the auth token somewhere in the podfile or elsewhere? |
|
@systemlevel pls see https://docs.mapbox.com/ios/maps/overview/#configure-credentials on how to configure |
|
@mfazekas Thank you! |
|
@mfazekas success with the Perhaps https://github.com/react-native-mapbox-gl/maps/pull/1052 assists with this potentially? |
|
@mfazekas https://github.com/react-native-mapbox-gl/maps/blob/65cab1c7f43deb2194dac95141529d1f610884c4/react-native-mapbox-gl.podspec Thank you! |
|
can you explain where/how I can set the |
|
@melvinmt, it is described here: https://github.com/react-native-mapbox-gl/maps/pull/940 |
|
@ferdicus great, that worked, thank you! |
Deprecates:
New version:
Note using 6.0 or later requires mapbox tokens in
~/.netrcfile:pls see https://docs.mapbox.com/ios/maps/overview/#configure-credentials on how to configure .netrc file