Skip to content

Support mapbox 6.0 and later and switch to $ReactNativeMapboxGLIOSVersion - #1044

Merged
mfazekas merged 2 commits into
rnmapbox:masterfrom
mfazekas:mfazekas/ios-fw-6-support
Oct 2, 2020
Merged

Support mapbox 6.0 and later and switch to $ReactNativeMapboxGLIOSVersion#1044
mfazekas merged 2 commits into
rnmapbox:masterfrom
mfazekas:mfazekas/ios-fw-6-support

Conversation

@mfazekas

@mfazekas mfazekas commented Sep 26, 2020

Copy link
Copy Markdown
Contributor

Deprecates:

ENV["REACT_NATIVE_MAPBOX_MAPBOX_IOS_VERSION"] = "6.2.1"

New version:

$ReactNativeMapboxGLIOSVersion = "6.2.1"

Note using 6.0 or later requires mapbox tokens in ~/.netrc file:
pls see https://docs.mapbox.com/ios/maps/overview/#configure-credentials on how to configure .netrc file

@mfazekas
mfazekas requested a review from ferdicus September 26, 2020 09:03

@ferdicus ferdicus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Are you also going to add some form of update into the changelog or do you think the deprecation warning is enough?

Comment thread scripts/autogenerate.js Outdated
@mfazekas

Copy link
Copy Markdown
Contributor Author

Thanks 👍

Are you also going to add some form of update into the changelog or do you think the deprecation warning is enough?

The env was in our changelog https://github.com/react-native-mapbox-gl/maps/blob/master/CHANGELOG.md#810rc2 i've added this deprecation not the that link as well.

@ferdicus

Copy link
Copy Markdown
Member

Thanks 👍
Are you also going to add some form of update into the changelog or do you think the deprecation warning is enough?

The env was in our changelog https://github.com/react-native-mapbox-gl/maps/blob/master/CHANGELOG.md#810rc2 i've added this deprecation not the that link as well.

Cool 👏

Should we also add the .netrc info to the iOS installation guide?

@ferdicus ferdicus linked an issue Sep 29, 2020 that may be closed by this pull request
@mfazekas
mfazekas force-pushed the mfazekas/ios-fw-6-support branch from e82a26f to 40a46cd Compare October 2, 2020 06:42
@mfazekas
mfazekas force-pushed the mfazekas/ios-fw-6-support branch from 40a46cd to 1f44113 Compare October 2, 2020 07:05
@mfazekas
mfazekas merged commit 409b0fd into rnmapbox:master Oct 2, 2020
@systemlevel

systemlevel commented Oct 2, 2020

Copy link
Copy Markdown
Contributor

Been having a bit of trouble understanding how to approach this for this PR. Looks like it might be attempting to download the correct SDK from Mapbox but I'm unauthorized. Do we place the auth token somewhere in the podfile or elsewhere?

@mfazekas

mfazekas commented Oct 2, 2020

Copy link
Copy Markdown
Contributor Author

@systemlevel pls see https://docs.mapbox.com/ios/maps/overview/#configure-credentials on how to configure .netrc file

@systemlevel

Copy link
Copy Markdown
Contributor

@mfazekas Thank you!

@systemlevel

systemlevel commented Oct 2, 2020

Copy link
Copy Markdown
Contributor

@mfazekas success with the .netrc file. However, any iOS SDK over 6.0.0 I'm getting a crash immediately when the app loads.

Dyld Error Message:

dyld: Using shared cache: 64C38D35-50E5-3FF4-A607-6D00F0234183

Library not loaded: @rpath/MapboxMobileEvents.framework/MapboxMobileEvents

Referenced from: /Users/USER/Library/Developer/CoreSimulator/Devices/16EE9272-941F-4B44-B6BB-1A500A55102D/data/Containers/Bundle/Application/0037690B-5056-4C48-8B50-5AD737820C11/MAPAPP.app/Frameworks/Mapbox.framework/Mapbox

Reason: image not found

Perhaps https://github.com/react-native-mapbox-gl/maps/pull/1052 assists with this potentially?

@systemlevel

Copy link
Copy Markdown
Contributor

@melvinmt

melvinmt commented Nov 3, 2020

Copy link
Copy Markdown

@mfazekas

can you explain where/how I can set the $ReactNativeMapboxGLIOSVersion variable?

@ferdicus

ferdicus commented Nov 4, 2020

Copy link
Copy Markdown
Member

@melvinmt

melvinmt commented Nov 4, 2020

Copy link
Copy Markdown

@ferdicus great, that worked, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade iOS SDK to 6.0.0

4 participants