Skip to content

fix: fix test-utils version to 1.3.0 - #615

Merged
joamag merged 1 commit into
masterfrom
dva/fix_test_util_version
Nov 3, 2022
Merged

fix: fix test-utils version to 1.3.0#615
joamag merged 1 commit into
masterfrom
dva/fix_test_util_version

Conversation

@3rdvision

@3rdvision 3rdvision commented Nov 2, 2022

Copy link
Copy Markdown
Contributor
- -
Issue - @vue/test-utils is throwing when building to run tests because of a breaking change after 1.3.0 version.
Decisions - Fix test-utils version to 1.3.0

@3rdvision 3rdvision added the bug Something isn't working label Nov 2, 2022
@vercel

vercel Bot commented Nov 2, 2022

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ripe-components-vue ✅ Ready (Inspect) Visit Preview Nov 2, 2022 at 5:56PM (UTC)

@ripe-tobias-bot

Copy link
Copy Markdown

Woof, Woof!

Thank you @3rdvision for submitting the "fix: fix test-utils version to 1.3.0" pull request 😎.

Please do not forget to review our internal guidelines:

  • Review the code in the PR using a peer 🧑‍🤝‍🧑
  • Make sure all the linting process has been executed an passed 👌
  • Make sure unit tests are passing ✅
  • Ensure that proper code standards are met 📋
  • Fill in the PR's summary (issue, dependencies, decisions and GIF)
  • Double-check the diff to make sure it's the absolute best solution you can come up with

Engaging in the development process in the best possible way helps it being efficient and fast.

Your friend,
Tobias (Platforme's mascot)

Tobias Bot

@ripe-tobias-bot

Copy link
Copy Markdown

Woof, Woof!

Oops! @3rdvision you may have to fix some errors:

  • Please specify a link to the issue or rationale in the description of the PR ❗️

Please address these issues to continue with the Pull Request merge process.

Your friend,
Tobias (Platforme's mascot)

Tobias Bot

@beneditomauro
beneditomauro requested a review from joamag November 3, 2022 09:52
@beneditomauro beneditomauro assigned joamag and unassigned beneditomauro Nov 3, 2022
@joamag

joamag commented Nov 3, 2022

Copy link
Copy Markdown
Contributor

@3rdvision we need to somehow mark this as temporary...

@joamag
joamag merged commit e1fcf05 into master Nov 3, 2022
@delete-merged-branch
delete-merged-branch Bot deleted the dva/fix_test_util_version branch November 3, 2022 10:54
@3rdvision

Copy link
Copy Markdown
Contributor Author

@joamag Issue and PR fix was opened for the vue-test-utils repo. When the issue is fixed, I'll receive a notification and bump back the versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants