Improve debugging support for the VM - #1142
Merged
Merged
Conversation
`call_compiled_body` mirrored `call_script_fn` except for the frame push/pop, so `back_trace()` saw nothing under the VM. Per-statement `dbg` calls, the `FunctionExit*` events and the `Terminate` callback are still absent — breakpoints and stepping remain inert under the VM.
`call_compiled_body` kept the debugger's call stack and nothing else, so break-points and stepping were inert. A `debugging` build now marks every statement, the VM stops at the markers, and leaving a body and reaching the end of a run are reported. A statement is the grain of it: `grain/mod.rs` says what an expression-level stop and a break-point on a name cost. A callback that declares a variable would move every slot after it, so what it declares does not outlive the stop.
Collaborator
|
LGTM... But need to fix the CI. I wasn't expecting to support the debugger interface with Grain, but if it can, why not! Kudos! |
Without the manifest entry, cargo builds the example in every configuration and it fails to compile wherever `rhai::grain` does not exist — which is every CI job that does not enable the feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add hooks to pass the debugging tests that previously failed. Also adds a disassembly example.