Skip to content

VM: Implement missing syntactic functions - #1138

Merged
schungx merged 5 commits into
rhaiscript:mainfrom
schungx:vm-impl-syntactic-fn
Aug 19, 2026
Merged

VM: Implement missing syntactic functions#1138
schungx merged 5 commits into
rhaiscript:mainfrom
schungx:vm-impl-syntactic-fn

Conversation

@schungx

@schungx schungx commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

The syntactic functions is_def_var and is_def_fn are missing from the VM.

This PR implements them.

@schungx
schungx requested a review from ImTheSquid August 18, 2026 04:00
@schungx schungx added bug vm Issues related to the Rhai Grain bytecodes compiler and VM. regression and removed bug labels Aug 18, 2026
@schungx
schungx force-pushed the vm-impl-syntactic-fn branch from 81c614c to 038528f Compare August 18, 2026 04:27
Comment thread src/grain/vm/mod.rs Outdated
Comment thread src/grain/vm/mod.rs Outdated
@schungx
schungx force-pushed the vm-impl-syntactic-fn branch from 038528f to 50676de Compare August 19, 2026 00:58
@schungx
schungx force-pushed the vm-impl-syntactic-fn branch from 50676de to ad12bdf Compare August 19, 2026 01:31
@schungx

schungx commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator Author

OK, I fixed up the two issues. Mainly, the call_syntactic and call_stacked pair is now extracted into a single call_syntactic_and_stacked... (I know, not very creative here)

Don't worry about the other small changes... they show up due to small commits on main.

@schungx
schungx merged commit 7a32157 into rhaiscript:main Aug 19, 2026
51 checks passed
@schungx
schungx deleted the vm-impl-syntactic-fn branch August 19, 2026 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

regression vm Issues related to the Rhai Grain bytecodes compiler and VM.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants