Ebpf lint - #642
Merged
Merged
Conversation
When running in a container, git detects a dubious ownership mismatch between the runner user and the checkout directory, causing the lint-ebpf target to fail: fatal: detected dubious ownership in repository at '/__w/retis/retis' Fix by configuring git to trust the directory before running the eBPF lint step. Signed-off-by: Paolo Valerio <pvalerio@redhat.com>
When building with V=1, out_console expanded to ':' which make echoed as a standalone line. Fix by making the verbose out_console expand to nothing and moving the trailing ';' into the non-verbose macro to avoid breaking shell syntax in the gen-bindings loop. Callsites are now more consistent (no trailing semicolon). Signed-off-by: Paolo Valerio <pvalerio@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ebpf linter is essentially broken because of git ownership.
While at it, add a small cosmetic fix in the build.