Skip to content

feat: add multiple schema deletions#397

Merged
evidolob merged 4 commits intoredhat-developer:masterfrom
p-spacek:feat/delete-multiple-schemas
Feb 15, 2021
Merged

feat: add multiple schema deletions#397
evidolob merged 4 commits intoredhat-developer:masterfrom
p-spacek:feat/delete-multiple-schemas

Conversation

@p-spacek
Copy link
Copy Markdown
Contributor

What does this PR do?

add schema modification to delete schemas from cache.

export enum MODIFICATION_ACTIONS {
  'delete',
  'add',
  'deleteWhole',
}

Motivation:

when dynamically changing shared schema, I use this deleteWhole schema action to delete old parent schemas from cache. So language server will reload parents schemas with updated referenced schema.

What issues does this PR fix or reference?

no ref

Is it tested? How?

added unit test

@coveralls
Copy link
Copy Markdown

coveralls commented Jan 25, 2021

Coverage Status

Coverage decreased (-0.07%) to 75.983% when pulling 653ce39 on p-spacek:feat/delete-multiple-schemas into 1802872 on redhat-developer:master.

Copy link
Copy Markdown
Contributor

@JPinkney JPinkney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, my only suggestion would be to change deleteWhole to deleteAll or something like that

@p-spacek
Copy link
Copy Markdown
Contributor Author

agree, had deleteAll before, but I overthink it...
renamed

@evidolob
Copy link
Copy Markdown
Collaborator

evidolob commented Feb 15, 2021

@p-spacek Can you update this PR? I'm going to merge it after.

@p-spacek
Copy link
Copy Markdown
Contributor Author

Sorry I didn't notice.
Resolved

@evidolob evidolob merged commit f0c5594 into redhat-developer:master Feb 15, 2021
@evidolob
Copy link
Copy Markdown
Collaborator

@p-spacek No problem. Thank you, for your contribution!

@p-spacek p-spacek deleted the feat/delete-multiple-schemas branch February 15, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants