Add code action to open json schema#395
Merged
evidolob merged 12 commits intoredhat-developer:masterfrom Feb 12, 2021
Merged
Conversation
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
JPinkney
reviewed
Jan 20, 2021
Contributor
JPinkney
left a comment
JPinkney
left a comment
There was a problem hiding this comment.
Other than my one comment and the github action comments it looks good to me
…rver into open-schema Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
…rver into open-schema Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
…rver into open-schema Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
…rver into open-schema
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds code action to open json schema, this code action will be available only for JSON Schema specific error/warnings, only for schemas which URI has
file(local schemas) orhttps(remote, usually for schema store).Demo:
VSCode extension part: redhat-developer/vscode-yaml#418
What issues does this PR fix or reference?
redhat-developer/vscode-yaml#174
Is it tested? How?
To test this you need redhat-developer/vscode-yaml#418 also, just build both and run extension, open any yaml file with schema associated, make some error in it, after error appeared in editor, there are yellow bulb should appeared for line with error, just click on it, an click on
Jump to schema locationand you should see JSON scheme opened in editor.