Provide default object as completion snippet#291
Merged
JPinkney merged 3 commits intoredhat-developer:masterfrom Aug 6, 2020
Merged
Provide default object as completion snippet#291JPinkney merged 3 commits intoredhat-developer:masterfrom
JPinkney merged 3 commits intoredhat-developer:masterfrom
Conversation
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Contributor
|
I've just tried testing this and it looks like I'm getting unexpected results. Attempting to autocomplete: in VSCode gives which is invalid YAML. I think it needs to do: |
Collaborator
Author
|
@JPinkney Yes, you are right |
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Contributor
|
I've tested with: and it looks like we get: I wonder if it makes sense to continously check every child value as well. I've just tried with json language server and it seems to work correctly: |
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Collaborator
Author
|
@JPinkney I done: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fix: redhat-developer/vscode-yaml#200