OpenShift Toolkit extension recommendation#892
Merged
msivasubramaniaan merged 5 commits intomainfrom Mar 2, 2023
Merged
Conversation
…kspace has devfile.yaml Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
rgrunber
reviewed
Mar 1, 2023
Member
rgrunber
left a comment
rgrunber
left a comment
There was a problem hiding this comment.
Change looks pretty good. Just some minor things to fix, and then I think we can merge.
Co-authored-by: Roland Grunberg <rgrunber@redhat.com>
Co-authored-by: Roland Grunberg <rgrunber@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
rgrunber
approved these changes
Mar 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR recommends OpenSift Toolkit extension when the workspace folder contains 'devfile.yaml'
What issues does this PR fix or reference?
redhat-developer/vscode-openshift-tools#2592
Is it tested? How?
Yes with UT