[Output] Drop checkstyle to avoid manual fixes in PRs - #5566
Merged
Conversation
TomasVotruba
enabled auto-merge (squash)
February 15, 2021 21:22
TomasVotruba
added a commit
that referenced
this pull request
Feb 6, 2024
rectorphp/rector-src@9a44c19 [Transform] Transform rules() to withRules() on RectorConfigBuilderRector (#5566)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert of https://github.com/rectorphp/rector/pull/3034/files
The idea of Rector is not to bother user with visual work, but handle it for them:
Checkstyle feature is going against this idea, so we're removing it.
We're trying to deliver Rector to the wider community, with lower PHP as PHP 5.6 and prefixed dependencies.
Current Rector code-base is now bloated with rule, that should have been implemented by community itself. This drags development itself down, we don't have coding power to maintain all this while developing new features and keeping up to date with legacy code requirements.
To this burden gropus belonged 3 Phalcon rules (#5313), Sonarcube (#5215) or events (#4865).
Saying that, we're dropping few rules, to be able to improve code base. We pick rules that can be adapated by community, like this. We'd be happy if this code is moved, maintained and used in external package as the idea itself is valid 👍
For inspiration, similar community work is done in:
We know it's not a convenient, but we hope you take it well for Rector be able to grow 🙂
Let us know if you need any help with migration. We'll be happy to help 👍