Revert "Build: pass PATH environment variable to Docker container (#10133)" - #10206
Closed
ericholscher wants to merge 3 commits into
Closed
Revert "Build: pass PATH environment variable to Docker container (#10133)"#10206ericholscher wants to merge 3 commits into
PATH environment variable to Docker container (#10133)"#10206ericholscher wants to merge 3 commits into
Conversation
This reverts commit 331e474.
ericholscher
force-pushed
the
revert-bc4bceda2a55497ee07a5a470f1a0d54200c6873
branch
from
March 28, 2023 19:26
8d3ed2e to
7b93e58
Compare
stsewd
approved these changes
Mar 28, 2023
stsewd
left a comment
Member
There was a problem hiding this comment.
Looks like we need to run pre-commit
Member
|
We may want to run pre-commit in another commit, and do a merge commit instead of squash+rebase, to avoid any conflicts when merging main into our release branches. |
Member
Author
|
I'm not really sure how to make this pass, it passes locally: |
Member
|
@ericholscher that's because the commit is already done, you can run |
Member
Author
|
This was merged into |
humitos
added a commit
that referenced
this pull request
May 22, 2023
This is another attempt to fix this issue. It follows the suggestion posted by @bensze01 in #10103. It looks simple and I think it makes sense to give it a try since it doesn't seem to be harmful. I tested it locally with the branch https://github.com/readthedocs/test-builds/tree/build-commands-multiline and it worked fine. Note that without this PR the branch linked fails. Related #10133 Related #10119 Related #10206 External PRs that should be solved by this one: * pypi/warehouse#12953 * pypi/warehouse#12953 Closes #10103 Closes #10208
humitos
added a commit
that referenced
this pull request
May 23, 2023
* Build: allow multi-line commands on `build.commands` This is another attempt to fix this issue. It follows the suggestion posted by @bensze01 in #10103. It looks simple and I think it makes sense to give it a try since it doesn't seem to be harmful. I tested it locally with the branch https://github.com/readthedocs/test-builds/tree/build-commands-multiline and it worked fine. Note that without this PR the branch linked fails. Related #10133 Related #10119 Related #10206 External PRs that should be solved by this one: * pypi/warehouse#12953 * pypi/warehouse#12953 Closes #10103 Closes #10208 * Build: use `;` to separate PREFIX from COMMAND
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts #10172 & #10133