Skip to content

[Namespacing] Prefix isUndefined with "CSS"#211

Closed
ide wants to merge 1 commit into
react:masterfrom
expo:namespace
Closed

[Namespacing] Prefix isUndefined with "CSS"#211
ide wants to merge 1 commit into
react:masterfrom
expo:namespace

Conversation

@ide

@ide ide commented Jul 26, 2016

Copy link
Copy Markdown
Contributor

Consistently namespace all of css-layout's public C API with "CSS". The only function that needed to be renamed was isUndefined, which I renamed to CSSValueIsUndefined.

Fixes #210.

Test Plan: Ran Buck tests.

@ghost ghost added the CLA Signed label Jul 26, 2016
@vjeux

vjeux commented Jul 26, 2016

Copy link
Copy Markdown
Contributor

👍

@emilsjolander

Copy link
Copy Markdown
Contributor

Looks good! I'm on vacation a couple days but will make sure to merge this next week. Thank you 👍

@emilsjolander

Copy link
Copy Markdown
Contributor

Could you please rebase?

@ghost

ghost commented Aug 2, 2016

Copy link
Copy Markdown

@ide updated the pull request.

@ghost ghost added the CLA Signed label Aug 2, 2016
Consistently namespace all of css-layout's public C API with "CSS". The only function that needed to be renamed was isUndefined, which I renamed to CSSValueIsUndefined.

Test Plan: Ran Buck tests.
@ghost

ghost commented Aug 4, 2016

Copy link
Copy Markdown

@ide updated the pull request.

@ghost ghost added the CLA Signed label Aug 4, 2016
@emilsjolander

Copy link
Copy Markdown
Contributor

Thanks! Merging now :) I made the necessary updated to react-native

ghost pushed a commit that referenced this pull request Aug 5, 2016
Summary:
Consistently namespace all of css-layout's public C API with "CSS". The only function that needed to be renamed was isUndefined, which I renamed to CSSValueIsUndefined.

Fixes #210.
Closes #211

Reviewed By: lucasr

Differential Revision: D3674922

Pulled By: emilsjolander

fbshipit-source-id: 1752f477bde45586db112fe2654d0404cc52e1d1
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants