[WIP] Initial implementation of Modal on Android #5320
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| package com.facebook.react.views.modalhost; | ||
|
|
||
| import com.facebook.react.uimanager.events.Event; | ||
| import com.facebook.react.uimanager.events.RCTEventEmitter; | ||
|
|
||
| /** | ||
| * {@link Event} for dismissing a Dialog. | ||
| */ | ||
| public class DismissEvent extends Event<DismissEvent> { | ||
|
|
||
| public static final String EVENT_NAME = "topDismiss"; | ||
|
|
||
| protected DismissEvent(int viewTag, long timestampMs) { | ||
| super(viewTag, timestampMs); | ||
| } | ||
|
|
||
| @Override | ||
| public String getEventName() { | ||
| return EVENT_NAME; | ||
| } | ||
|
|
||
| @Override | ||
| public void dispatch(RCTEventEmitter rctEventEmitter) { | ||
| rctEventEmitter.receiveEvent(getViewTag(), getEventName(), null); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| // Copyright 2004-present Facebook. All Rights Reserved. | ||
|
Contributor
There was a problem hiding this comment. nit: add the BSD license header please |
||
|
|
||
| package com.facebook.react.views.modalhost; | ||
|
|
||
| import android.content.DialogInterface; | ||
| import android.graphics.Color; | ||
| import android.graphics.drawable.ColorDrawable; | ||
| import android.os.SystemClock; | ||
|
|
||
| import com.facebook.react.common.MapBuilder; | ||
| import com.facebook.react.uimanager.ThemedReactContext; | ||
| import com.facebook.react.uimanager.UIManagerModule; | ||
| import com.facebook.react.uimanager.ViewGroupManager; | ||
| import com.facebook.react.uimanager.annotations.ReactProp; | ||
|
|
||
| import java.util.Map; | ||
|
|
||
| /** | ||
| * View manager for {@link ReactModalHostView} components. | ||
| * | ||
| * Emits an {@code onDismiss} event when the Dialog host is dismissed. | ||
| */ | ||
| public class ReactModalHostManager extends ViewGroupManager<ReactModalHostView> { | ||
|
|
||
| private static final String REACT_CLASS = "RCTModalHostView"; | ||
|
|
||
| @ReactProp(name = "animated") | ||
| public void setAnimated(ReactModalHostView view, boolean animated) { | ||
| // TODO(8776300): Implement this | ||
| } | ||
|
|
||
| @ReactProp(name = "transparent") | ||
| public void setTransparent(ReactModalHostView view, boolean transparent) { | ||
| if (transparent) { | ||
| view.setBackgroundDrawable(new ColorDrawable(Color.TRANSPARENT)); | ||
| } else { | ||
| view.setBackgroundDrawable(new ColorDrawable(Color.WHITE)); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public String getName() { | ||
| return REACT_CLASS; | ||
| } | ||
|
|
||
| @Override | ||
| protected ReactModalHostView createViewInstance(ThemedReactContext reactContext) { | ||
| return new ReactModalHostView(reactContext); | ||
| } | ||
|
|
||
| @Override | ||
| protected void addEventEmitters( | ||
| final ThemedReactContext reactContext, | ||
| final ReactModalHostView view) { | ||
| view.setOnDismissListener( | ||
| new DialogInterface.OnDismissListener() { | ||
| @Override | ||
| public void onDismiss(DialogInterface dialog) { | ||
| reactContext.getNativeModule(UIManagerModule.class) | ||
| .getEventDispatcher() | ||
| .dispatchEvent(new DismissEvent(view.getId(), SystemClock.uptimeMillis())); | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| @Override | ||
| public Map<String, Object> getExportedCustomDirectEventTypeConstants() { | ||
| return MapBuilder.<String, Object>builder() | ||
| .put(DismissEvent.EVENT_NAME, MapBuilder.of("registrationName", "onDismiss")) | ||
| .build(); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| package com.facebook.react.views.modalhost; | ||
|
Contributor
There was a problem hiding this comment. nit: add a license header please |
||
|
|
||
| import android.app.Dialog; | ||
| import android.content.Context; | ||
| import android.content.DialogInterface; | ||
| import android.graphics.drawable.ColorDrawable; | ||
| import android.view.View; | ||
| import android.view.ViewGroup; | ||
| import android.view.WindowManager; | ||
|
|
||
| import com.facebook.react.common.annotations.VisibleForTesting; | ||
| import com.facebook.react.views.view.ReactViewGroup; | ||
|
|
||
| /** | ||
| * A Modal view that works as a base ViewGroup to host other views. | ||
| */ | ||
| public class ReactModalHostView extends ViewGroup { | ||
|
|
||
| private ReactViewGroup mHostView; | ||
| private Dialog mDialog; | ||
|
|
||
| public ReactModalHostView(Context context) { | ||
| super(context); | ||
|
|
||
| mHostView = new ReactViewGroup(context); | ||
| mHostView.setLayoutParams(new LayoutParams(LayoutParams.MATCH_PARENT, LayoutParams.MATCH_PARENT)); | ||
|
|
||
| mDialog = new Dialog(context, android.R.style.Theme_DeviceDefault_Dialog_NoActionBar); | ||
| mDialog.setContentView(mHostView); | ||
| mDialog.show(); | ||
| mDialog.getWindow().setLayout( | ||
| WindowManager.LayoutParams.MATCH_PARENT, | ||
| WindowManager.LayoutParams.MATCH_PARENT); | ||
| } | ||
|
|
||
| public void setBackgroundDrawable(ColorDrawable color) { | ||
| mDialog.getWindow().setBackgroundDrawable(color); | ||
| } | ||
|
|
||
| @Override | ||
| protected void onLayout(boolean changed, int l, int t, int r, int b) { | ||
| } | ||
|
|
||
| @Override | ||
| public void addView(View child, int index) { | ||
| mHostView.addView(child, index); | ||
| } | ||
|
|
||
| @Override | ||
| public int getChildCount() { | ||
| return mHostView.getChildCount(); | ||
| } | ||
|
|
||
| @Override | ||
| public View getChildAt(int index) { | ||
| return mHostView.getChildAt(index); | ||
| } | ||
|
|
||
| @Override | ||
| public void removeView(View child) { | ||
| mHostView.removeView(child); | ||
| } | ||
|
|
||
| /*package*/ void setOnDismissListener(DialogInterface.OnDismissListener listener) { | ||
| mDialog.setOnDismissListener(listener); | ||
| } | ||
|
|
||
| @VisibleForTesting | ||
| public Dialog getDialog() { | ||
| return mDialog; | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: add the BSC license header please