Skip to content

Null check on Picker Items #24057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Rahulkishanm wants to merge 4 commits into from
Closed

Null check on Picker Items #24057

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
26b7ce5
Null check on Picker Items
Rahulkishanm Mar 20, 2019
a56bfef
Lint fix
Rahulkishanm Mar 20, 2019
be7db85
Update PickerIOS.ios.js
cpojer Mar 20, 2019
3344b56
Lint fix2
Rahulkishanm Mar 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Libraries/Components/Picker/PickerIOS.ios.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ class PickerIOS extends React.Component<Props, State> {
static getDerivedStateFromProps(props: Props): State {
let selectedIndex = 0;
const items = [];
React.Children.toArray(props.children).forEach(function(child, index) {
React.Children.toArray(props.children).filter(child => child !== null).forEach(function(child, index) {
Comment thread
Rahulkishanm marked this conversation as resolved.
Outdated
if (child.props.value === props.selectedValue) {
selectedIndex = index;
}
Expand Down