breaking: Remove cli-debugger-ui package#2583
Merged
huntie merged 1 commit intoJan 28, 2025
Merged
Conversation
2 tasks
huntie
force-pushed
the
remove-remote-debugging-1
branch
from
a793852 to
1afce36
Compare
szymonrybczak
left a comment
szymonrybczak
left a comment
Collaborator
There was a problem hiding this comment.
Left some comments, overall looks good!
Collaborator
Author
|
Very good spots @szymonrybczak — sorry I rebased my branch from my fork's |
Collaborator
Author
|
For safety, latest push is a recreation of the commit after rebasing and re-deleting/searching for references. |
huntie
force-pushed
the
remove-remote-debugging-1
branch
from
1afce36 to
5efa968
Compare
szymonrybczak
approved these changes
Jan 27, 2025
szymonrybczak
left a comment
szymonrybczak
left a comment
Collaborator
There was a problem hiding this comment.
Looks good now, thanks!
2 tasks
huntie
force-pushed
the
remove-remote-debugging-1
branch
from
5efa968 to
60d96aa
Compare
Collaborator
|
@huntie there's a conflict in |
huntie
force-pushed
the
remove-remote-debugging-1
branch
from
60d96aa to
57ba392
Compare
Collaborator
Author
|
@szymonrybczak Resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Important
Breaking change: This is intended to target
main/ the future18.xrelease of CLI (aligned with React Native 0.79).Following our intent/announcement to remove Remote JS Debugging from React Native in 0.78, this PR removes the corresponding
cli-debugger-uifrontend from the Community CLI.Also deletes related middleware/WebSocket support code in
cli-server-api:/launch-js-devtoolsdebuggerProxyEndpointTest Plan:
✅ CI should pass
Checklist