Add remote debugging deprecation header - #2081
Merged
thymikee merged 1 commit intoSep 20, 2023
Merged
Conversation
huntie
commented
Sep 19, 2023
| </p> | ||
| <p> | ||
| Please use the | ||
| <strong>Open Debugger</strong> workflow to debug apps using Hermes |
Collaborator
Author
There was a problem hiding this comment.
@motiz88 One thought here is whether we should mention or link any info on future JSC direct debugging capabilities — i.e. pointing to an umbrella issue on GitHub that we open during 0.73's lifetime, to gather signal on users who may need this. This issue would reinforce that JSC debugging is no longer directly supported, but that we're looking for interested owners to implement JSC support in the new debugging stack.
Member
There was a problem hiding this comment.
@huntie please feel free to followup on this in a separate PR if you feel this is gonna be helpful
thymikee
reviewed
Sep 19, 2023
huntie
force-pushed
the
deprecate-jsc-remote-debugging
branch
from
September 19, 2023 13:50
a78e061 to
46404e0
Compare
thymikee
approved these changes
Sep 19, 2023
szymonrybczak
approved these changes
Sep 19, 2023
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In React Native 0.73 we are deprecating Remote JSC Debugging (the
/debugger-uiendpoint). This PR adds an informational warning header to this page as a signal to users of this change.This will be supported by (upcoming) improvements to React Native's debugging docs.
Test plan