Skip to content

[Android] Prepare auto-linking for double publishing - #2076

Merged
thymikee merged 1 commit into
react-native-community:mainfrom
cipolleschi:cipolleschi/support_new_arch_enabled_from_version
Sep 14, 2023
Merged

[Android] Prepare auto-linking for double publishing#2076
thymikee merged 1 commit into
react-native-community:mainfrom
cipolleschi:cipolleschi/support_new_arch_enabled_from_version

Conversation

@cipolleschi

@cipolleschi cipolleschi commented Sep 14, 2023

Copy link
Copy Markdown
Contributor

Summary:

With this change, we are preparing the CLI to support double publishing of React Native.
This change should be transparent to our users until we set up a version of React Native that is different from 0.X.Y

Test Plan:

Tested the code with RNTester.

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@cipolleschi
cipolleschi force-pushed the cipolleschi/support_new_arch_enabled_from_version branch from 892eefc to b4c4242 Compare September 14, 2023 09:12
@cipolleschi
cipolleschi marked this pull request as ready for review September 14, 2023 09:35
@cipolleschi
cipolleschi force-pushed the cipolleschi/support_new_arch_enabled_from_version branch from b4c4242 to 9462af6 Compare September 14, 2023 10:15

@cortinico cortinico left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@thymikee
thymikee merged commit d695144 into react-native-community:main Sep 14, 2023
@cipolleschi
cipolleschi deleted the cipolleschi/support_new_arch_enabled_from_version branch September 14, 2023 12:36
facebook-github-bot pushed a commit to react/react-native that referenced this pull request Sep 18, 2023
Summary:
Pull Request resolved: #39502

This diff adds the parsing of the package.json to retrieve the version of react native and it matches it against a regex to decide whether to enable or not the New Architecture.

This change depends on [this CLI's PR](react-native-community/cli#2076).

## Changelog:
[Android][Added] - Parse RN Version to decide whether to enable the New Arch or not.

Reviewed By: cortinico

Differential Revision: D49270012

fbshipit-source-id: 5164a1ddd26f1822c0d717a7a9e2416ec38d78a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants