Skip to content

fix: Adjust wording for dev server port taken messages - #2067

Merged
thymikee merged 1 commit into
react-native-community:mainfrom
huntie:debugging-cleanup-3
Sep 11, 2023
Merged

fix: Adjust wording for dev server port taken messages#2067
thymikee merged 1 commit into
react-native-community:mainfrom
huntie:debugging-cleanup-3

Conversation

@huntie

@huntie huntie commented Sep 8, 2023

Copy link
Copy Markdown
Collaborator

Summary

Simplifies "port taken" messages to replace [packager|Metro|Metro Bundler] with "dev server", matching recent changes in @react-native/community-cli-plugin.

};

export const logAlreadyRunningBundler = (port: number) => {
logger.info(`Metro Bundler is already for this project on port ${port}.`);

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Fixes typo!

@szymonrybczak szymonrybczak left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@thymikee
thymikee merged commit 45c868f into react-native-community:main Sep 11, 2023
@huntie
huntie deleted the debugging-cleanup-3 branch September 11, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants