breaking: Delete source for cli-plugin-metro, remove from builtin commands - #2055
Merged
thymikee merged 1 commit intoSep 6, 2023
Merged
Conversation
huntie
changed the title
thymikee
reviewed
Aug 11, 2023
thymikee
reviewed
Aug 11, 2023
thymikee
reviewed
Aug 11, 2023
huntie
force-pushed
the
remove-cli-plugin-metro
branch
3 times, most recently
from
August 11, 2023 17:24
e07465a to
337041f
Compare
Collaborator
Author
|
@thymikee @szymonrybczak Once react/react-native#39059 is merged, this will be safe to ship in the next alpha. The removed internally-linked |
huntie
force-pushed
the
remove-cli-plugin-metro
branch
from
August 18, 2023 10:37
337041f to
c9b3aed
Compare
2 tasks
huntie
force-pushed
the
remove-cli-plugin-metro
branch
from
August 21, 2023 10:56
c9b3aed to
49454e3
Compare
facebook-github-bot
pushed a commit
to react/react-native
that referenced
this pull request
Aug 22, 2023
Summary: Pull Request resolved: #39059 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes This change: - Links the new `react-native/dev-middleware` endpoints into the recently migrated `react-native start` command. - Adds `react-native/community-cli-plugin` (the migrated [`cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro)) as a dependency of `react-native`, and hooks in these versions of the `start`, `bundle`, and `ram-bundle` commands via `react-native.config.js`. Functionally, this means that the new `/open-debugger` endpoint is available on the dev server started by `react-native start` (not yet linked into any UI). After this PR is merged, the new `community-cli-plugin` package is "linked" and we can remove `cli-plugin-metro` from `react-native-community/cli`: react-native-community/cli#2055. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D47226421 fbshipit-source-id: 123039961f93bd8183a32a2d3f30c447f7c0f132
huntie
marked this pull request as ready for review
August 22, 2023 16:24
Collaborator
Author
|
@thymikee @szymonrybczak Ready to merge. Latest synced changes to |
szymonrybczak
approved these changes
Aug 23, 2023
huntie
force-pushed
the
remove-cli-plugin-metro
branch
from
August 23, 2023 13:52
49454e3 to
4935d67
Compare
facebook-github-bot
pushed a commit
to react/react-native
that referenced
this pull request
Aug 23, 2023
Summary: Pull Request resolved: #39127 Will be referenced in react-native-community/cli#2055. Changelog: [Internal] bypass-github-export-checks Reviewed By: motiz88 Differential Revision: D48603224 fbshipit-source-id: 0b31d765f912cf8efe4300f7490ccef3ac843a41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Following the work in react/react-native#38795 and #2021, this:
@react-native-community/cli-plugin-metropackage, which is now@react-native/community-cli-plugin.@react-native-community/cli-plugin-metrocommands frompackages/cli/src/commands/index.ts.Changelog: [Breaking] The
start,bundle, andram-bundlecommands are no longer included with@react-native-community/cliand have moved into the internals ofreact-nativewhere they will be pre-configured. This must be used in conjunction with the React Nativemainbranch.Test Plan
In https://github.com/facebook/react-native, the
start,bundleandram-bundlehave been re-configured as a CLI plugin by thereact-nativepackage.react-native startreact-native bundlereact-native ram-bundle✅ Commands are integrated as before