Skip to content

DataView: forward align on Filters/DisplayControls, and let Search control its leading icon #848

Description

@ravisuhag

Summary

Two DataView controls hard-code a positioning / rendering detail and expose no prop to change it, even though the underlying primitive already supports it.

  1. DataView.Filters and DataView.DisplayControls — popup alignment is fixed.
  2. DataView.Search — the leading magnifier icon can't be removed or replaced.

1. Forward align on Filters and DisplayControls

  • DataView.DisplayControls exposes trigger + hideViewSwitcher/hideOrdering/hideGrouping/hideDisplayProperties, but no align.
  • DataView.Filters exposes trigger + classNames, but no align.

The underlying Menu.Content / Popover.Content already extend Base UI's Positioner.Props and accept align / side / sideOffset; these controls just don't forward them.

Request: expose align (and ideally side / sideOffset) on both DataView.Filters and DataView.DisplayControls, forwarding to the underlying menu / popover. Default to today's behavior. Base UI's Positioner already handles collision flip/shift, so this is prop-forwarding only.

2. Let Search control its leading icon

DataView.Search extends the base Search, whose props are Omit<InputProps, 'leadingIcon'>. The base Input accepts leadingIcon, but Search removes it and hard-codes a magnifier, with no supported way to hide or replace it.

Request: re-expose leadingIcon on Search (settable to a custom node or null), or add a showSearchIcon={false} / hideIcon flag. Default keeps the magnifier.

Willing to contribute

Happy to open a PR if the approach looks right.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions