Change source lists for mbedtls - #3095
Open
peterharperuk wants to merge 1 commit into
Open
Conversation
Currently we list the mbedtls source files in some complicated variables which change depending on the version in use. This makes it hard to know if you have all the source files needed. Instead, just copy the source file lists from the mbedtls CMakeLists.txt file into our own included cmake file. This should reduce the chance of us missing files in future. See raspberrypi#3081
|
Much better approach IMO. I also ran into something similar in LWIP, so maybe this approach could be used there as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we list the mbedtls source files in some complicated variables which change depending on the version in use.
This makes it hard to know if you have all the source files needed.
Instead, just copy the source file lists from the mbedtls CMakeLists.txt file into our own included cmake file.
This should reduce the chance of us missing files in future.
See #3081