Skip to content
This repository was archived by the owner on Apr 16, 2026. It is now read-only.

Ensure Mnesia is running when Khepri is used as main metadata store - #292

Merged
michaelklishin merged 1 commit into
rabbitmq:mainfrom
cloudamqp:4_0
Oct 2, 2024
Merged

Ensure Mnesia is running when Khepri is used as main metadata store#292
michaelklishin merged 1 commit into
rabbitmq:mainfrom
cloudamqp:4_0

Conversation

@gomoripeti

@gomoripeti gomoripeti commented Oct 1, 2024

Copy link
Copy Markdown
Contributor

Proposed Changes

This plugin still uses a pair of Mnesia tables. If not running, Mnesia is started in a single-node cluster mode. This is enough, as the used tables are not replicated.

(As discussed in #291)

CT tests to be added.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

If this is a relatively large or complex change, kick off the discussion by
explaining why you chose the solution you did and what alternatives you
considered, etc.

This plugin still uses a pair of Mnesia tables. If not running, Mnesia
is started in a single-node cluster mode. This is enough, as the used
tables are not replicated.
@michaelklishin michaelklishin added this to the 4.0.2 milestone Oct 2, 2024
@michaelklishin

Copy link
Copy Markdown
Contributor

This version does work with Khepri enabled. I am testing an "upgrade" to Khepri next.

@michaelklishin

Copy link
Copy Markdown
Contributor

A switch to Khepri with a node restart works as expected. Thank you, @gomoripeti.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants