This repository was archived by the owner on Apr 16, 2026. It is now read-only.
Conversion to float numbers implemented in try_convert_to_int - #198
Merged
michaelklishin merged 1 commit intoMay 14, 2022
Conversation
|
@unknovvn Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@unknovvn Thank you for signing the Contributor License Agreement! |
michaelklishin
approved these changes
May 14, 2022
Contributor
|
Thank you! |
michaelklishin
added a commit
that referenced
this pull request
May 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Conversion to float numbers added in try_convert_to_int.
try_convert_to_int function tries to convert value passed with header "x-delay" into int. But currently it only supports string to int conversion. Certain languages (for example .NET) have common API for time utilities (TimeSpan.TotalMilliseconds) which return double type value. If it is not casted into integer type before passing it to header as a value - it is being ignored in the try_convert_to_int and there is no way (except for looking into plugin source code) why it didn't work.
Note regarding tests. I wasn't able to pass all tests with or without my changes. If someone would assist with help how to run them properly - would be able to add tests for my changes.
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
CONTRIBUTING.mddocument