Skip to content
This repository was archived by the owner on Apr 16, 2026. It is now read-only.

Conversion to float numbers implemented in try_convert_to_int - #198

Merged
michaelklishin merged 1 commit into
rabbitmq:masterfrom
unknovvn:Conversion-to-float-numbers-added-in-try_convert_to_int
May 14, 2022
Merged

Conversion to float numbers implemented in try_convert_to_int#198
michaelklishin merged 1 commit into
rabbitmq:masterfrom
unknovvn:Conversion-to-float-numbers-added-in-try_convert_to_int

Conversation

@unknovvn

@unknovvn unknovvn commented May 14, 2022

Copy link
Copy Markdown
Contributor

Proposed Changes

Conversion to float numbers added in try_convert_to_int.

try_convert_to_int function tries to convert value passed with header "x-delay" into int. But currently it only supports string to int conversion. Certain languages (for example .NET) have common API for time utilities (TimeSpan.TotalMilliseconds) which return double type value. If it is not casted into integer type before passing it to header as a value - it is being ignored in the try_convert_to_int and there is no way (except for looking into plugin source code) why it didn't work.

Note regarding tests. I wasn't able to pass all tests with or without my changes. If someone would assist with help how to run them properly - would be able to add tests for my changes.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

@pivotal-cla

Copy link
Copy Markdown

@unknovvn Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla

Copy link
Copy Markdown

@unknovvn Thank you for signing the Contributor License Agreement!

@michaelklishin
michaelklishin merged commit fc2622d into rabbitmq:master May 14, 2022
@michaelklishin

Copy link
Copy Markdown
Contributor

Thank you!

@michaelklishin michaelklishin added this to the 3.10.1 milestone May 14, 2022
michaelklishin added a commit that referenced this pull request May 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants