fix(quickemu): select the first complete firmware pair - #1938
Open
Qusic wants to merge 1 commit into
Open
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No issues found across 1 file
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Fixes a firmware selection bug by validating both the CODE and VARS files exist and stopping at the first complete pair. The change is small, bounded, maintains intended ordering, and is backed by tests.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The firmware search currently checks only the CODE file and keeps scanning, so a later incomplete or lower-priority candidate can overwrite a valid preferred pair.
Require both CODE and VARS to exist, then stop at the first complete pair. This preserves the declared order, including the Microsoft-key Nix pair added by #1879.
Related: #543 previously proposed the same complete-pair validation and first-match behavior.
Testing
bash -n quickemushellcheck quickemunix build path:.#quickemuType of change
Checklist: