Skip to content

Fixing minor issues with default listing#809

Merged
jordens merged 2 commits into
mainfrom
rs/serial-console-cleanup
Nov 14, 2023
Merged

Fixing minor issues with default listing#809
jordens merged 2 commits into
mainfrom
rs/serial-console-cleanup

Conversation

@ryan-summers

@ryan-summers ryan-summers commented Nov 14, 2023

Copy link
Copy Markdown
Member

When deserializing, the MAC is skipped, and we need to set it so we know the default UID. Otherwise, the defaults show the MAC as 00-00-00-00-00-00. After the change:

PS C:\Users\rsummers> python -m serial COM22
--- Miniterm on COM22  9600,8,N,1 ---
--- Quit: Ctrl+] | Menu: Ctrl+T | Help: Ctrl+T followed by Ctrl+H ---

Input was empty?

> list
Available items:
/broker: "mqtt" [default: "mqtt"]
/id: "04-91-62-d2-a8-6f" [default: "04-91-62-d2-a8-6f"]

@ryan-summers
ryan-summers requested a review from jordens November 14, 2023 12:25
@jordens
jordens added this pull request to the merge queue Nov 14, 2023
Merged via the queue into main with commit e7149cd Nov 14, 2023
@ryan-summers
ryan-summers deleted the rs/serial-console-cleanup branch November 14, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants