add limits calculation and helper script to plot the frequency response#603
Merged
Conversation
jordens
requested changes
Aug 24, 2022
jordens
left a comment
jordens
left a comment
Member
There was a problem hiding this comment.
nice, just a few minor things.
jordens
reviewed
Aug 24, 2022
jordens
approved these changes
Aug 24, 2022
Member
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small PR to add gain limits to the IIR coefficient calculations. I've also added a small helper to quickly plot the frequency response of the filter. I found it hard without that to just guess the parameters for the ballpark response that I want because I need to extrapolate the gains from 1 Hz.