Indicating stabilizer status via MQTT will#468
Merged
Conversation
jordens
approved these changes
Dec 7, 2021
Member
Author
|
bors merge |
bors Bot
added a commit
that referenced
this pull request
Dec 7, 2021
468: Indicating stabilizer status via MQTT will r=ryan-summers a=ryan-summers This PR fixes #302 by utilizing a miniconf version that uses the <prefix>/alive topic to indicate life status of stabilizer. This branch was run locally and ethernet was pulled. It was observed that after 2 and a half minutes, the `<prefix>/alive` topic was published as 0. We may want to reduce the keep-alive interval, as it appears the will is only published after 2.5x the keepalive interval has elapsed. Co-authored-by: Ryan Summers <ryan.summers@vertigo-designs.com>
Member
Author
|
bors merge |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #302 by utilizing a miniconf version that uses the /alive topic to indicate life status of stabilizer.
This branch was run locally and ethernet was pulled. It was observed that after 2 and a half minutes, the
<prefix>/alivetopic was published as 0.We may want to reduce the keep-alive interval, as it appears the will is only published after 2.5x the keepalive interval has elapsed.