Skip to content

Feature/streaming hitl#426

Merged
bors[bot] merged 9 commits into
masterfrom
feature/streaming-hitl
Aug 10, 2021
Merged

Feature/streaming hitl#426
bors[bot] merged 9 commits into
masterfrom
feature/streaming-hitl

Conversation

@ryan-summers

@ryan-summers ryan-summers commented Aug 5, 2021

Copy link
Copy Markdown
Member

This PR fixes #386 by implementing HITL tests for the data livestream functionalities of Stabilizer.

@github-actions github-actions Bot added the changes-hitl Changes HITL scripts, needs close review label Aug 5, 2021
@ryan-summers
ryan-summers marked this pull request as ready for review August 9, 2021 11:56
@ryan-summers

Copy link
Copy Markdown
Member Author

bors try

bors Bot added a commit that referenced this pull request Aug 9, 2021
@bors

bors Bot commented Aug 9, 2021

Copy link
Copy Markdown
Contributor

try

Build failed:

@ryan-summers

Copy link
Copy Markdown
Member Author

bors try

bors Bot added a commit that referenced this pull request Aug 9, 2021
@bors

bors Bot commented Aug 9, 2021

Copy link
Copy Markdown
Contributor

try

Build succeeded:

@ryan-summers

Copy link
Copy Markdown
Member Author

@jordens Do you have any ideas in regards to the shared code between this and scripts/stream_throughput.py? I'm not a fan of duplicating the code in both places, but I'm not sure what a good way to structure it would be otherwise.

Comment thread hitl/streaming.py Outdated
Comment thread hitl/streaming.py Outdated
Comment thread hitl/streaming.py Outdated
@ryan-summers
ryan-summers requested a review from jordens August 9, 2021 14:25
Comment thread hitl/run.sh Outdated
Co-authored-by: Robert Jördens <rj@quartiq.de>
@ryan-summers

Copy link
Copy Markdown
Member Author

bors try

bors Bot added a commit that referenced this pull request Aug 9, 2021
@bors

bors Bot commented Aug 9, 2021

Copy link
Copy Markdown
Contributor

try

Build failed:

@ryan-summers

Copy link
Copy Markdown
Member Author

bors try

bors Bot added a commit that referenced this pull request Aug 10, 2021
@bors

bors Bot commented Aug 10, 2021

Copy link
Copy Markdown
Contributor

try

Build succeeded:

@ryan-summers
ryan-summers requested a review from jordens August 10, 2021 11:33
@ryan-summers

Copy link
Copy Markdown
Member Author

bors merge

@bors

bors Bot commented Aug 10, 2021

Copy link
Copy Markdown
Contributor

Build succeeded:

@bors
bors Bot merged commit 4bfa3cb into master Aug 10, 2021
@bors
bors Bot deleted the feature/streaming-hitl branch August 10, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changes-hitl Changes HITL scripts, needs close review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HITL for streaming

2 participants