Refactoring lockin binaries#352
Merged
Merged
Conversation
ryan-summers
commented
May 6, 2021
Merged
Member
Author
|
Alright, testing on Stabilizer with an oscilloscope shows that both channels are independently configurable and @jordens This is ready for review whenever you get a chance. |
jordens
approved these changes
May 6, 2021
Member
|
bors merge |
bors Bot
added a commit
that referenced
this pull request
May 6, 2021
352: Refactoring lockin binaries r=jordens a=ryan-summers This PR merges `lockin-external` and `lockin-internal` into a single binary. This has also refactored the output configuration to make it more configurable. This was needed to work well with the reference signal generation, as that output should necessarily just override a different setting. Co-authored-by: Ryan Summers <ryan.summers@vertigo-designs.com> Co-authored-by: Robert Jördens <rj@quartiq.de>
Member
Author
|
bors cancel |
Contributor
|
Canceled. |
Member
Author
|
bors merge |
bors Bot
added a commit
that referenced
this pull request
May 6, 2021
352: Refactoring lockin binaries r=ryan-summers a=ryan-summers This PR merges `lockin-external` and `lockin-internal` into a single binary. This has also refactored the output configuration to make it more configurable. This was needed to work well with the reference signal generation, as that output should necessarily just override a different setting. Co-authored-by: Ryan Summers <ryan.summers@vertigo-designs.com> Co-authored-by: Robert Jördens <rj@quartiq.de>
Member
Author
|
bors cancel |
Contributor
|
Canceled. |
Member
Author
|
bors merge |
Contributor
|
Build succeeded: |
bors Bot
added a commit
that referenced
this pull request
May 10, 2021
341: Feature/telemetry r=ryan-summers a=ryan-summers This PR fixes #149 This PR adds the following: * A `SystemTimer` used for RTIC scheduling (required for schedule periods > ~2 seconds) * A refactor of the `src/net` directory * Addition of network stack sharing via proxy (identical to implementation from `shared-bus`) * Addition of a telemetry task This must be merged after #352 Future Work: * move `src/net/shared.rs` into `embedded-nal` or some other separate crate. * Investigate removal of shared network stack by making smoltcp sockets owned and interrupt-safe Co-authored-by: Ryan Summers <ryan.summers@vertigo-designs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR merges
lockin-externalandlockin-internalinto a single binary.This has also refactored the output configuration to make it more configurable. This was needed to work well with the reference signal generation, as that output should necessarily just override a different setting.