Skip to content

HITL Check Update#349

Merged
bors[bot] merged 3 commits into
masterfrom
feature/hitl-rework
Apr 29, 2021
Merged

HITL Check Update#349
bors[bot] merged 3 commits into
masterfrom
feature/hitl-rework

Conversation

@ryan-summers

Copy link
Copy Markdown
Member

Updating the HITL workflow to create the check locally before having the remote repository create it. This makes it belong to a deterministic test suite and always exist

@ryan-summers ryan-summers changed the title Feature/hitl rework HITL Check Update Apr 29, 2021
@ryan-summers

Copy link
Copy Markdown
Member Author

bors try

1 similar comment
@ryan-summers

Copy link
Copy Markdown
Member Author

bors try

@bors

bors Bot commented Apr 29, 2021

Copy link
Copy Markdown
Contributor

try

Already running a review

@ryan-summers

Copy link
Copy Markdown
Member Author

bors try

@bors

bors Bot commented Apr 29, 2021

Copy link
Copy Markdown
Contributor

try

Already running a review

@ryan-summers

Copy link
Copy Markdown
Member Author

bors try

@bors

bors Bot commented Apr 29, 2021

Copy link
Copy Markdown
Contributor

try

Already running a review

@ryan-summers

Copy link
Copy Markdown
Member Author

bors try

@bors

bors Bot commented Apr 29, 2021

Copy link
Copy Markdown
Contributor

try

Already running a review

@ryan-summers

Copy link
Copy Markdown
Member Author

bors try

@bors

bors Bot commented Apr 29, 2021

Copy link
Copy Markdown
Contributor

try

Already running a review

@jordens

jordens commented Apr 29, 2021

Copy link
Copy Markdown
Member

Worth adding timeout_sec = 1200 to bors.toml so it doesn't wait an hour to timeout for a check that never arrives.

@jordens

jordens commented Apr 29, 2021

Copy link
Copy Markdown
Member

And in this case, I'd just push to master.

@ryan-summers

Copy link
Copy Markdown
Member Author

bors merge

bors Bot added a commit that referenced this pull request Apr 29, 2021
349: HITL Check Update r=ryan-summers a=ryan-summers

Updating the HITL workflow to create the check locally before having the remote repository create it. This makes it belong to a deterministic test suite and always exist

Co-authored-by: Ryan Summers <ryan.summers@vertigo-designs.com>
@ryan-summers

Copy link
Copy Markdown
Member Author

bors cancel

@bors

bors Bot commented Apr 29, 2021

Copy link
Copy Markdown
Contributor

Canceled.

@ryan-summers

Copy link
Copy Markdown
Member Author

bors try

@bors

bors Bot commented Apr 29, 2021

Copy link
Copy Markdown
Contributor

try

Already running a review

@ryan-summers

Copy link
Copy Markdown
Member Author

bors merge

bors Bot added a commit that referenced this pull request Apr 29, 2021
349: HITL Check Update r=ryan-summers a=ryan-summers

Updating the HITL workflow to create the check locally before having the remote repository create it. This makes it belong to a deterministic test suite and always exist

Co-authored-by: Ryan Summers <ryan.summers@vertigo-designs.com>
@ryan-summers

Copy link
Copy Markdown
Member Author

bors cancel

@bors

bors Bot commented Apr 29, 2021

Copy link
Copy Markdown
Contributor

Canceled.

@ryan-summers

Copy link
Copy Markdown
Member Author

bors merge

bors Bot added a commit that referenced this pull request Apr 29, 2021
349: HITL Check Update r=ryan-summers a=ryan-summers

Updating the HITL workflow to create the check locally before having the remote repository create it. This makes it belong to a deterministic test suite and always exist

Co-authored-by: Ryan Summers <ryan.summers@vertigo-designs.com>
@bors

bors Bot commented Apr 29, 2021

Copy link
Copy Markdown
Contributor

Build failed:

@ryan-summers

Copy link
Copy Markdown
Member Author

bors retry

@ryan-summers

Copy link
Copy Markdown
Member Author

bors merge

@bors

bors Bot commented Apr 29, 2021

Copy link
Copy Markdown
Contributor

Already running a review

@bors

bors Bot commented Apr 29, 2021

Copy link
Copy Markdown
Contributor

Build succeeded:

@bors
bors Bot merged commit 339332d into master Apr 29, 2021
@bors
bors Bot deleted the feature/hitl-rework branch April 29, 2021 12:36
@bors

bors Bot commented Apr 29, 2021

Copy link
Copy Markdown
Contributor

try

Merge conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants