Refactoring to support multiple apps#230
Merged
ryan-summers merged 4 commits intoJan 20, 2021
Merged
Conversation
jordens
approved these changes
Jan 19, 2021
Member
There was a problem hiding this comment.
Nice.
I think that we'll want to have the files with src/main.rs -> bin/dual-iir.rs and then src/lib.rs collecting all the exports. Like https://github.com/knurling-rs/app-template/tree/main/src
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #218 by configuring all hardware interfaces to a default-off state. They may be enabled by using the associated
start()function, which allows for selective usage of adcs/dacs/timestampers. Additionally, all hardware configuration has been moved tosrc/hardware/configuration.rsto facilitate easily writing multiple applications without copying the initialization code.@jordens Would you mind taking a look at the structure? I haven't touched the
idletask as I believe that will be changing significantly as soon as we refactor to use MQTT and the new settings configurations.Testing
I ran a square wave input signal to ADC0 and measured the expected output signal on DAC0 with the expected delay.