Skip to content

Added cascaded IIR with server commands for up to 2 cascaded IIRs per…#187

Merged
bors[bot] merged 3 commits into
quartiq:masterfrom
nkuh:biquadCascadeDma
Dec 4, 2020
Merged

Added cascaded IIR with server commands for up to 2 cascaded IIRs per…#187
bors[bot] merged 3 commits into
quartiq:masterfrom
nkuh:biquadCascadeDma

Conversation

@nkuh

@nkuh nkuh commented Dec 3, 2020

Copy link
Copy Markdown
Contributor

… channel.

Note: If the number of cascaded IIRs is set to 1 the still existent server commands for the unused 2nd cascade level will be aliases for the 1st level.

@jordens jordens left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Two minor style nits.

Comment thread src/main.rs Outdated
Comment thread src/main.rs Outdated
@jordens

jordens commented Dec 4, 2020

Copy link
Copy Markdown
Member

bors r+

bors Bot added a commit that referenced this pull request Dec 4, 2020
187: Added cascaded IIR with server commands for up to 2 cascaded IIRs per… r=jordens a=nkuh

… channel.

Note: If the number of cascaded IIRs is set to 1 the still existent server commands for the unused 2nd cascade level will be aliases for the 1st level. 

Co-authored-by: Niklas Kuhrmeyer <niklas.kuhrmeyer@ptb.de>
Co-authored-by: Robert Jördens <rj@quartiq.de>
@bors

bors Bot commented Dec 4, 2020

Copy link
Copy Markdown
Contributor

Canceled.

@jordens

jordens commented Dec 4, 2020

Copy link
Copy Markdown
Member

bors retry

@bors

bors Bot commented Dec 4, 2020

Copy link
Copy Markdown
Contributor

Build succeeded:

@bors
bors Bot merged commit e873763 into quartiq:master Dec 4, 2020
@nkuh
nkuh deleted the biquadCascadeDma branch December 7, 2020 08:01
@nkuh nkuh mentioned this pull request Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants