[3.36] Update Quarkus Flow to 0.10.2 - #2009
Conversation
Status for workflow
|
|
This PR should target branch 3.33, which is the latest LTS, not 3.36. |
|
This is even a bit strange as there is no 3.36 branch in the config https://github.com/quarkusio/quarkus-platform/blob/main/.github/update-quarkus-platform.yml (If I understood correctly how it should work). I am reviewing the Action run that does this update. I see some errors there (maybe not connected) https://github.com/quarkusio/quarkus-platform/actions/runs/27189929380/job/80267435800#step:5:229. May be worth investigating. And for some reason I see it switches to 3.36 https://github.com/quarkusio/quarkus-platform/actions/runs/27189929380/job/80267435800#step:5:584, even when I don't see it in the config. |
|
@ricardozanini we were not part of the platform in 3.33. So it is correct that this PR is wrong, but based on what I saw, there should be just 1 PR to main. (edited - This PR may not be wrong, please see my next comment) |
|
Apart from branches in the yaml configuration, it resolves also latest "version" branch from the Platform repository, which is currently 3.36. It processes that branch as the last one (which is seen in the logs I linked earlier). @gsmet I have a question about the updates, please. In the updates, it used the same version of Quarkus Flow to do update for Platform main and also for 3.36. However one Quarkus Flow release is aligned with one specific Quarkus and Platform version. I think that using the same version in updates for multiple branches may be not correct as I expect each branch in Platform is aligned with a specific Quarkus version. Is this correct, please? Should all members of the Platform in a specific branch use the same Quarkus version? If yes, I think there should be some mechanism in the update process to differentiate around this, so no update of a member version is done with a release that is using a different Quarkus version than expected in a Platform branch. What do you think, please? |
|
Member could be built against different Quarkus versions, there shouldn't be any problem with that. For example, the version of the Hazelcast Client extension currently included in the platform was built with Quarkus 3.26.2 (as can be seen in https://repo.maven.apache.org/maven2/io/quarkus/platform/quarkus-hazelcast-client-quarkus-platform-descriptor/3.36.1/quarkus-hazelcast-client-quarkus-platform-descriptor-3.36.1-3.36.1.json) And it was last updated in the platform in version 3.28.0.CR1, which can be seen here https://github.com/quarkusio/quarkus-platform/blob/main/pom.xml#L429 That means it stayed unchanged since then, while other members kept rebuilding (or not) against newer Quarkus versions. |
|
@aloubyansky, thanks for the clarification; that was what I thought regarding extensions depending on any specific Quarkus version and still being a member of the platform. So now this PR makes sense, thanks! |
|
Thank you @aloubyansky for clarification. Then agree, this PR is fine. |
Updates the Quarkus Platform member Quarkus Flow from
0.10.0to0.10.2.Changes
quarkus-flow.versionfrom0.10.0to0.10.2./mvnw -Dsyncto synchronize the platformArtifact
io.quarkiverse.flow:quarkus-flow-bomThis PR was automatically created by the Update Quarkus Platform Action.
/cc @ricardozanini @baldimir