Fix #929 by updating Eigen to version 3.4.1 - #934
Merged
Conversation
mhucka
marked this pull request as ready for review
November 4, 2025 01:41
mhucka
added
a: health
For consistency, let's use the same symbol.
sergeisakov
approved these changes
Nov 4, 2025
mhucka
changed the title
github-actions
Bot
added
size: XS
I'm not sure where I got the previous commit hash from, but this one now is the right one for Eigen 3.4.1. Source: https://gitlab.com/libeigen/eigen/-/releases/3.4.1
github-actions
Bot
added
size: S
Apparently I had the wrong sha?
mhucka
added a commit
to mhucka/qsim
that referenced
this pull request
Jan 18, 2026
The warning described in quantumlib#929 seems to be the result of using an older version of Eigen. Updating the version makes the warning go go away.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The warning described in #929 seems to be the result of using an older version of Eigen. Updating the version makes the warning go go away.