-
Notifications
You must be signed in to change notification settings - Fork 122
Create a bloq for galois multiplication #1557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
NoureldinYosri
merged 14 commits into
quantumlib:main
from
NoureldinYosri:galois_mod_mul
Mar 31, 2025
Merged
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
31c480a
checkpoint
NoureldinYosri c8cd837
Create a bloq for galois multiplication
NoureldinYosri 15ace21
fix QGF
NoureldinYosri eef7ea0
nit
NoureldinYosri cd0614e
checkpoint
NoureldinYosri 9299c00
address comments
NoureldinYosri acf7fdd
nit
NoureldinYosri 4cd7005
Merge branch 'main' into galois_mod_mul
NoureldinYosri 2290fb4
nit
NoureldinYosri bb9ba09
nit
NoureldinYosri d32616a
docs
NoureldinYosri 7ce8723
nit
NoureldinYosri dc3d11e
notebooks
NoureldinYosri 2fc04bd
Merge branch 'main' into galois_mod_mul
tanujkhattar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test to
data_types_test.pywith examples of whichQGFtypes should be equal and which should be different.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, can you remind me again why we needed to add
element_reprto theQGFclass in the first place? ]It looks like its a property of the
GFclass that can be easily modified by callinggf_type.repr(int). If this is used mainly as a tool for debugging and visualizing the field elements, then its better to not have it as part of theQGFclass and simply change the property on the underlyingQGF.galois_fieldtype wherever needed.https://mhostetter.github.io/galois/v0.3.5/api/galois.FieldArray.element_repr/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed