Maked intermediate additions unsigned in ModAdd - #1424
Merged
Merged
Conversation
Merged
Contributor
|
this is the only line that needs changing |
Contributor
Author
|
Both lines ended up needing changing; I tested it with the error showing up in my ECAdd PR. |
Contributor
yea, makes sense that all additions are unsigned |
NoureldinYosri
enabled auto-merge (squash)
September 28, 2024 07:27
NoureldinYosri
disabled auto-merge
September 28, 2024 07:31
NoureldinYosri
enabled auto-merge (squash)
September 28, 2024 07:31
NoureldinYosri
approved these changes
Sep 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replicate bug with ModAdd(bitsize=8, mod=17).adjoint().on_classical_vals(x=0,y=0). Basically, we do signed integer addition with registers that have unsigned dtypes. Change the intermediate register dtypes to QInt to perform modular reductions then restore to unsigned int dtypes.