Add QROAMClean and QROAMCleanAdjoint bloqs for data loading - #1291
Merged
Merged
Conversation
fdmalone
reviewed
Aug 15, 2024
fdmalone
reviewed
Aug 15, 2024
fdmalone
reviewed
Aug 15, 2024
fdmalone
reviewed
Aug 15, 2024
fdmalone
reviewed
Aug 15, 2024
fdmalone
reviewed
Aug 15, 2024
fdmalone
reviewed
Aug 15, 2024
fdmalone
reviewed
Aug 15, 2024
fdmalone
reviewed
Aug 15, 2024
fdmalone
reviewed
Aug 15, 2024
fdmalone
requested changes
Aug 15, 2024
fdmalone
left a comment
fdmalone
left a comment
Collaborator
There was a problem hiding this comment.
Awesome. Looking good just some questions / nits.
fdmalone
approved these changes
Aug 15, 2024
tanujkhattar
enabled auto-merge (squash)
August 15, 2024 19:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #368
The only variation left after this is a
QROAMDirtybloq, which allocatesk-1dirty registers and assumes target is in 0 state initially. Since the constant factors of this construction are very similar toSelectSwapQROM(leading order terms are identical), it's not a priority to add this version right now.More work needs to be done to add (a) Docstrings, (b) Replace uses of
QROAMandQROAMTwoRegsin chemistry using the newly added Bloqs and eventually add a decomposition forQROAMCleanAdjointthat uses measurement based un-computation; but everything else is setup correctly.Here are some pictures: