Skip to content

Improve support for CAdd - #1277

Merged
NoureldinYosri merged 3 commits into
quantumlib:mainfrom
NoureldinYosri:cadd
Aug 13, 2024
Merged

NoureldinYosri merged 3 commits into
quantumlib:mainfrom
NoureldinYosri:cadd

Conversation

@NoureldinYosri

Copy link
Copy Markdown
Contributor

This is a followup PR to #864 that

  • adds a notebook for CAdd
  • fixes classical action and adds classical action tests
  • replaces the decomposition. The old decomposition is buggy and failed classical tests. Instead I use a simple decomposition that uses $n$ ancillas.
  • adds tests for decomposition and symbolic costs

PS: we should probably replace this decomposition with the old one when we fix the bug in the old one.

Comment thread qualtran/bloqs/arithmetic/controlled_addition.py Outdated
@mpharrigan

Copy link
Copy Markdown
Collaborator

Let's track somewhere the task that Add().controlled() returns this bloq

@NoureldinYosri

Copy link
Copy Markdown
Contributor Author

I created #1278 to track making Add.controlled() return CAdd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants