Skip to content

Update Pylint dependency to 4.0+ - #1445

Merged
mhucka merged 5 commits into
quantumlib:mainfrom
mhucka:update-pylint
Aug 18, 2026
Merged

Update Pylint dependency to 4.0+#1445
mhucka merged 5 commits into
quantumlib:mainfrom
mhucka:update-pylint

Conversation

@mhucka

@mhucka mhucka commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

This simply does the minimum to update the version of Pylint to 4.0.x.

@mhucka
mhucka requested a review from arettig August 18, 2026 05:03
@mhucka
mhucka marked this pull request as ready for review August 18, 2026 05:09

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades Pylint to version 4.0 and Astroid to version 4.0, updating the .pylintrc configuration accordingly. It also cleans up various environment requirement files by removing legacy compatibility packages (such as tomli, exceptiongroup, and importlib-metadata) and unifying the cirq-core dependency. A review comment suggests updating an outdated comment in .pylintrc regarding the renamed extension-pkg-allow-list option.

Comment thread .pylintrc
Per Gemini Code Assist's review comment, removing an outdated
parenthetical remark.
rosspeili added a commit to rosspeili/OpenFermion that referenced this pull request Aug 18, 2026
…t 4.0

Restore the existing copyright year, drop the parenthetical about setup.py, pin pylint to 4.0 to match quantumlib#1445, and pick up the package description and pytest helper deps from main.

@arettig arettig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this will change the minimum python version for the developers to 3.11, while 3.10 is still supported for users. Is this discrepancy fine? I guess we are not actually testing with 3.10 in the CI anyways, so maybe this is fine.

@mhucka

mhucka commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator Author

It looks like this will change the minimum python version for the developers to 3.11, while 3.10 is still supported for users. Is this discrepancy fine? I guess we are not actually testing with 3.10 in the CI anyways, so maybe this is fine.

Sorry, where does it change the minimum Python version? Pylint 4.0.x is supposed to be compatible with 3.10, and I don't see a change elsewhere that would require 3.11.

@arettig

arettig commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Sorry, where does it change the minimum Python version? Pylint 4.0.x is supposed to be compatible with 3.10, and I don't see a change elsewhere that would require 3.11.

The removed lines from the env files remove conditional dependencies for python < 3.11 (e.g. here), such as older versions of Cirq.

When running pip install -r dev_tools/requirements/envs/dev.env.txt using python 3.10.20 I get: ERROR: No matching distribution found for cirq-core==1.6.1.

If it wasn't pylint, maybe uv is using the current python version as the minimum when generating the env files?

@mhucka

mhucka commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator Author

Sorry, where does it change the minimum Python version? Pylint 4.0.x is supposed to be compatible with 3.10, and I don't see a change elsewhere that would require 3.11.

The removed lines from the env files remove conditional dependencies for python < 3.11 (e.g. here), such as older versions of Cirq.

Oh, argh, I missed that in the diff. It's probably due to how uv is getting run by the script. I'll check it.

@mhucka

mhucka commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator Author

Update: yes, uv needs to be given an option to tell it what Python version to target. I must have run the script in 3.11 when I did this PR, not realizing it. On the plus side, we just found an important fix to make to create-env-files.sh. I'll do a separate PR for that.

@mhucka

mhucka commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator Author

Update: regenerated corrected environment files.

Thanks again for catching that. I am once again reminded why it's good to have human reviewers :-).

@mhucka
mhucka requested a review from arettig August 18, 2026 20:13

@arettig arettig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing the uv outputs!

@mhucka
mhucka enabled auto-merge August 18, 2026 20:18
@mhucka
mhucka added this pull request to the merge queue Aug 18, 2026
Merged via the queue into quantumlib:main with commit b9609ba Aug 18, 2026
23 checks passed
rosspeili added a commit to rosspeili/OpenFermion that referenced this pull request Aug 19, 2026
…t 4.0

Restore the existing copyright year, drop the parenthetical about setup.py, pin pylint to 4.0 to match quantumlib#1445, and pick up the package description and pytest helper deps from main.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants