Update Pylint dependency to 4.0+ - #1445
Conversation
There was a problem hiding this comment.
Code Review
This pull request upgrades Pylint to version 4.0 and Astroid to version 4.0, updating the .pylintrc configuration accordingly. It also cleans up various environment requirement files by removing legacy compatibility packages (such as tomli, exceptiongroup, and importlib-metadata) and unifying the cirq-core dependency. A review comment suggests updating an outdated comment in .pylintrc regarding the renamed extension-pkg-allow-list option.
Per Gemini Code Assist's review comment, removing an outdated parenthetical remark.
…t 4.0 Restore the existing copyright year, drop the parenthetical about setup.py, pin pylint to 4.0 to match quantumlib#1445, and pick up the package description and pytest helper deps from main.
arettig
left a comment
There was a problem hiding this comment.
It looks like this will change the minimum python version for the developers to 3.11, while 3.10 is still supported for users. Is this discrepancy fine? I guess we are not actually testing with 3.10 in the CI anyways, so maybe this is fine.
Sorry, where does it change the minimum Python version? Pylint 4.0.x is supposed to be compatible with 3.10, and I don't see a change elsewhere that would require 3.11. |
The removed lines from the env files remove conditional dependencies for python < 3.11 (e.g. here), such as older versions of Cirq. When running If it wasn't pylint, maybe |
Oh, argh, I missed that in the diff. It's probably due to how uv is getting run by the script. I'll check it. |
|
Update: yes, |
|
Update: regenerated corrected environment files. Thanks again for catching that. I am once again reminded why it's good to have human reviewers :-). |
arettig
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing the uv outputs!
…t 4.0 Restore the existing copyright year, drop the parenthetical about setup.py, pin pylint to 4.0 to match quantumlib#1445, and pick up the package description and pytest helper deps from main.
This simply does the minimum to update the version of Pylint to 4.0.x.