Skip to content

Fix more typing issues #7388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dstrain115 merged 3 commits into from
May 30, 2025
Merged

Fix more typing issues #7388

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a9fbd1
Fix more typing issues
dstrain115 May 29, 2025
027316f
Add more specific type ignore statements.
dstrain115 May 30, 2025
2b03c42
Fix half of missing types.
dstrain115 May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 20 additions & 20 deletions cirq-core/cirq/circuits/_bucket_priority_queue_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
from cirq.circuits._bucket_priority_queue import BucketPriorityQueue


def test_init():
q = BucketPriorityQueue()
def test_init() -> None:
q: BucketPriorityQueue = BucketPriorityQueue()
assert not q.drop_duplicate_entries
assert list(q) == []
assert len(q) == 0
Expand All @@ -42,7 +42,7 @@ def test_init():
assert bool(q)


def test_eq():
def test_eq() -> None:
eq = cirq.testing.EqualsTester()
eq.add_equality_group(
BucketPriorityQueue(),
Expand Down Expand Up @@ -71,8 +71,8 @@ def test_eq():
)


def test_enqueue_dequeue():
q = BucketPriorityQueue()
def test_enqueue_dequeue() -> None:
q: BucketPriorityQueue = BucketPriorityQueue()
q.enqueue(5, 'a')
assert q == BucketPriorityQueue([(5, 'a')])
q.enqueue(4, 'b')
Expand All @@ -85,10 +85,10 @@ def test_enqueue_dequeue():
_ = q.dequeue()


def test_drop_duplicates_enqueue():
q0 = BucketPriorityQueue()
q1 = BucketPriorityQueue(drop_duplicate_entries=False)
q2 = BucketPriorityQueue(drop_duplicate_entries=True)
def test_drop_duplicates_enqueue() -> None:
q0: BucketPriorityQueue = BucketPriorityQueue()
q1: BucketPriorityQueue = BucketPriorityQueue(drop_duplicate_entries=False)
q2: BucketPriorityQueue = BucketPriorityQueue(drop_duplicate_entries=True)
for q in [q0, q1, q2]:
for _ in range(2):
q.enqueue(0, 'a')
Expand All @@ -97,10 +97,10 @@ def test_drop_duplicates_enqueue():
assert q2 == BucketPriorityQueue([(0, 'a')], drop_duplicate_entries=True)


def test_drop_duplicates_dequeue():
q0 = BucketPriorityQueue()
q1 = BucketPriorityQueue(drop_duplicate_entries=False)
q2 = BucketPriorityQueue(drop_duplicate_entries=True)
def test_drop_duplicates_dequeue() -> None:
q0: BucketPriorityQueue = BucketPriorityQueue()
q1: BucketPriorityQueue = BucketPriorityQueue(drop_duplicate_entries=False)
q2: BucketPriorityQueue = BucketPriorityQueue(drop_duplicate_entries=True)
for q in [q0, q1, q2]:
q.enqueue(0, 'a')
q.enqueue(0, 'b')
Expand All @@ -113,11 +113,11 @@ def test_drop_duplicates_dequeue():
assert q2 == BucketPriorityQueue([(0, 'b'), (0, 'a')], drop_duplicate_entries=True)


def test_same_priority_fifo():
def test_same_priority_fifo() -> None:
a = (5, 'a')
b = (5, 'b')
for x, y in [(a, b), (b, a)]:
q = BucketPriorityQueue()
q: BucketPriorityQueue = BucketPriorityQueue()
q.enqueue(*x)
q.enqueue(*y)
assert q
Expand All @@ -127,23 +127,23 @@ def test_same_priority_fifo():
assert not q


def test_supports_arbitrary_offsets():
def test_supports_arbitrary_offsets() -> None:
m = 1 << 60

q_neg = BucketPriorityQueue()
q_neg: BucketPriorityQueue = BucketPriorityQueue()
q_neg.enqueue(-m + 0, 'b')
q_neg.enqueue(-m - 4, 'a')
q_neg.enqueue(-m + 4, 'c')
assert list(q_neg) == [(-m - 4, 'a'), (-m, 'b'), (-m + 4, 'c')]

q_pos = BucketPriorityQueue()
q_pos: BucketPriorityQueue = BucketPriorityQueue()
q_pos.enqueue(m + 0, 'b')
q_pos.enqueue(m + 4, 'c')
q_pos.enqueue(m - 4, 'a')
assert list(q_pos) == [(m - 4, 'a'), (m, 'b'), (m + 4, 'c')]


def test_repr():
def test_repr() -> None:
r = repr(BucketPriorityQueue(entries=[(1, 2), (3, 4)], drop_duplicate_entries=True))
assert r.endswith('BucketPriorityQueue(entries=[(1, 2), (3, 4)], drop_duplicate_entries=True)')

Expand All @@ -154,7 +154,7 @@ def test_repr():
)


def test_str():
def test_str() -> None:
s = str(BucketPriorityQueue(entries=[(1, 2), (3, 4)], drop_duplicate_entries=True))
assert (
s
Expand Down
Loading