Simplify StatePreparationAliasSampling tests by relying on Cirq simulators to simulate operations allocating ancillas - #6204
Merged
tanujkhattar merged 3 commits intoJul 17, 2023
Conversation
…ators capability to simulate operations allocating ancilla qubits
tanujkhattar
enabled auto-merge (squash)
July 17, 2023 22:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6197
The two changes are
cirq.Simulatorto simulate operations that can allocate new ancilla qubitsGreedyQubitManageris not required for an optimal ancilla allocation; and aSimpleQubitManageralso works fine. This is useful becausecirq.Simulatorby default usesSimpleQubitManagerto decompose operations and the trivial strategy results in all Unary Iteration based gates to allocate a LOT more ancillas than needed.As part of looking into this issue, I also identified a general improvement that we can make to Cirq simulators s.t. for simulating operations that can allocate ancilla qubits, the simulation is optimized by potentially using
SimulationProductStateinstead ofStateVectorSimulationStateto simulate the decomposed operations (right now, the former is used only at the top-level circuit simulation). But we can track this in a separate issue.