Conversation
verult
requested review from
a team,
cduck,
vtomole and
wcourtney
as code owners
June 14, 2022 23:48
Contributor
Author
|
Some test failures are caused by initializing the cirq_google Sycamore devices in init files. These devices are instantiated using Is there a way to disable deprecation warning assertions during init? Alternatively, we could move Sycamore devices to |
Contributor
I suppose this is the culprit? Cirq/cirq-google/cirq_google/devices/known_devices.py Lines 339 to 341 in c504c38 I think the right move is to convert this to the new, intended format (GridDevice?), but it's not immediately clear how we would handle deprecating the old |
Contributor
Author
Yup Definitely agree that deprecating Sycamore prior to replacing is the ideal approach, but deprecating won't resolve the error here I think, because there will still be warnings causing tests to fail. |
CirqBot
pushed a commit
that referenced
this pull request
Jun 17, 2022
Blocking SerializableDevice deprecation (#5522) Recirq needs to be updated to use `Sycamore.metadata.qubit_set` in a follow-up. I put deprecation warnings as docstrings/comments since I don't expect them to have much usage outside Cirq (one exception being `_SYCAMORE_DURATION_PICOS` is used on server side to serialize DeviceSpecification the old way). Let me know if you'd prefer a full deprecation warning. @dstrain115 cc @MichaelBroughton @mpharrigan
This was referenced Jun 18, 2022
verult
marked this pull request as draft
June 19, 2022 19:41
CirqBot
pushed a commit
that referenced
this pull request
Jun 20, 2022
* Migrate the different `processor.get_device()` methods and `Engine.get_engine_device()` to GridDevice * Deprecate the `gate_sets` parameter in various `get_device()` methods, and remove `gate_sets` usages. A dedicated deprecation decorator was added in order to handle `gate_sets` parameter being passed in as a positional argument. Originally I had planned to do this after the 0.15 release, but because library code is not allowed to rely on deprecated code within tests, this is blocking SerializableDevice deprecation (#5522). @dstrain115 @MichaelBroughton
CirqBot
pushed a commit
that referenced
this pull request
Jun 21, 2022
Moves the various device-related functions in `virtual_engine_processor.py` to GridDevice. This is blocking SerializableDevice deprecation (#5522) because library code cannot call the deprecated SerializableDevice. * Rerouted functions in `virtual_engine_processor.py` to `GridDevice` * Deprecated the `gate_sets` parameter in `virtual_engine_processor.py` * Move `create_device_from_processor_id()` to GridDevice. @95-martin-orion * Made the return type more general by changing it to `cirq.Device` to allow for new device implementations in the future. * Created copies of existing rainbow and weber DeviceSpecifications and changed them to match the new DeviceSpecification format. * This update needs to happen now because `create_noiseless_virtual_engine_from_templates()` is updated to return a `GridDevice`, and the templates (rainbow and weber DeviceSpecifications) need to contain data in the new format in order to parse into GridDevice properly. * There are no publicly available devices since weber, so I chose to repurpose the existing rainbow and weber information. This was done manually since these devices are no longer available. * Gateset and gate_duration information should match previous versions. In particular, they both include the CZ gate with no duration information. **Reviewer Note**: The first 3 commits are from another pending PR (#5558); please start with the commit "[Move virtual engine functions to GridDevice](2e9ef33)". Don't be discouraged by the line count :) other than the 3 borrowed commits, ~600 lines are from the two new DeviceSpecification messages. @mpharrigan cc @MichaelBroughton @dstrain115
verult
force-pushed
the
cg-device-refactor/serializable-device-deprecation
branch
from
June 22, 2022 00:10
f7ae076 to
ce17a45
Compare
verult
force-pushed
the
cg-device-refactor/serializable-device-deprecation
branch
from
June 22, 2022 00:46
ce17a45 to
cc5246f
Compare
verult
marked this pull request as ready for review
June 22, 2022 00:46
Contributor
Author
|
This is ready to for review! @MichaelBroughton @dstrain115 |
MichaelBroughton
approved these changes
Jun 22, 2022
Collaborator
There was a problem hiding this comment.
LGTM, do we still want to use the from_proto @dstrain115 ?
Contributor
Author
|
There are a few references on the server side and in Recirq, but they can easily be swapped to GridDevice since they all expect a |
verult
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
Contributor
Author
|
Confirmed with @dstrain115 offline - we want to move to GridDevice entirely so |
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Blocking SerializableDevice deprecation (quantumlib#5522) Recirq needs to be updated to use `Sycamore.metadata.qubit_set` in a follow-up. I put deprecation warnings as docstrings/comments since I don't expect them to have much usage outside Cirq (one exception being `_SYCAMORE_DURATION_PICOS` is used on server side to serialize DeviceSpecification the old way). Let me know if you'd prefer a full deprecation warning. @dstrain115 cc @MichaelBroughton @mpharrigan
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
* Migrate the different `processor.get_device()` methods and `Engine.get_engine_device()` to GridDevice * Deprecate the `gate_sets` parameter in various `get_device()` methods, and remove `gate_sets` usages. A dedicated deprecation decorator was added in order to handle `gate_sets` parameter being passed in as a positional argument. Originally I had planned to do this after the 0.15 release, but because library code is not allowed to rely on deprecated code within tests, this is blocking SerializableDevice deprecation (quantumlib#5522). @dstrain115 @MichaelBroughton
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Moves the various device-related functions in `virtual_engine_processor.py` to GridDevice. This is blocking SerializableDevice deprecation (quantumlib#5522) because library code cannot call the deprecated SerializableDevice. * Rerouted functions in `virtual_engine_processor.py` to `GridDevice` * Deprecated the `gate_sets` parameter in `virtual_engine_processor.py` * Move `create_device_from_processor_id()` to GridDevice. @95-martin-orion * Made the return type more general by changing it to `cirq.Device` to allow for new device implementations in the future. * Created copies of existing rainbow and weber DeviceSpecifications and changed them to match the new DeviceSpecification format. * This update needs to happen now because `create_noiseless_virtual_engine_from_templates()` is updated to return a `GridDevice`, and the templates (rainbow and weber DeviceSpecifications) need to contain data in the new format in order to parse into GridDevice properly. * There are no publicly available devices since weber, so I chose to repurpose the existing rainbow and weber information. This was done manually since these devices are no longer available. * Gateset and gate_duration information should match previous versions. In particular, they both include the CZ gate with no duration information. **Reviewer Note**: The first 3 commits are from another pending PR (quantumlib#5558); please start with the commit "[Move virtual engine functions to GridDevice](quantumlib@2e9ef33)". Don't be discouraged by the line count :) other than the 3 borrowed commits, ~600 lines are from the two new DeviceSpecification messages. @mpharrigan cc @MichaelBroughton @dstrain115
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
To be replaced by GridDevice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be replaced by GridDevice.