Add IonQTargetGateset and use it for circuit compilations. - #5479
Merged
Merged
Conversation
tanujkhattar
requested review from
a team,
ColemanCollins,
cduck,
dabacon,
gmauricio,
nakardo and
vtomole
as code owners
June 10, 2022 09:01
Contributor
|
Thanks for picking this up! LGTM, but I don't think I can approve for some reason |
dabacon
approved these changes
Jun 10, 2022
dabacon
left a comment
dabacon
left a comment
Collaborator
There was a problem hiding this comment.
Two small comments, but LGTM
tanujkhattar
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
the
automerge
CirqBot
removed
the
front_of_queue_automerge
This was referenced Jun 13, 2022
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
…b#5479) Fixes quantumlib#5129 quantumlib#4901 quantumlib#4153 Replaces quantumlib#5127 * Adds support for compiling > 2q operations to ionq's target gateset * Does not do the "merge 2q operations to a connected component" optimization, to preserve existing behavior. We can add another `preprocess_transformer` if we want to do the optimization. * Deprecates `cirq_ionq.decompose_to_device` in favour of using `cirq.optimize_for_target_gateset(circuit, gateset=cirq_ionq.IonQTargetGateset)` for compiling circuits. cc @Cynocracy @dabacon
mhucka
added a commit
to mhucka/Cirq
that referenced
this pull request
Mar 28, 2025
Removed mention of `decompose_operation`. Issue quantumlib#5497 talks about updating the IonQ documentation to describe the use of transformers for compilation introduced in quantumlib#5479. This commit does not address that.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 31, 2025
* Fix #5497 Removed mention of `decompose_operation`. Issue #5497 talks about updating the IonQ documentation to describe the use of transformers for compilation introduced in #5479. This commit does not address that. * Fix example of circuit transformation for IonQ-native gates Replace and test the outdated example code (cirq.Circuit does not take a `device` argument anymore). --------- Co-authored-by: Pavol Juhas <juhas@google.com>
BichengYing
pushed a commit
to BichengYing/Cirq
that referenced
this pull request
Jun 20, 2025
…uantumlib#7198) * Fix quantumlib#5497 Removed mention of `decompose_operation`. Issue quantumlib#5497 talks about updating the IonQ documentation to describe the use of transformers for compilation introduced in quantumlib#5479. This commit does not address that. * Fix example of circuit transformation for IonQ-native gates Replace and test the outdated example code (cirq.Circuit does not take a `device` argument anymore). --------- Co-authored-by: Pavol Juhas <juhas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5129 #4901 #4153
Replaces #5127
preprocess_transformerif we want to do the optimization.cirq_ionq.decompose_to_devicein favour of usingcirq.optimize_for_target_gateset(circuit, gateset=cirq_ionq.IonQTargetGateset)for compiling circuits.cc @Cynocracy @dabacon