Update quantum_run_stream to not prefetch first result - #5024
Merged
Conversation
maffoo
requested review from
a team,
cduck,
verult,
vtomole and
wcourtney
as code owners
February 25, 2022 07:55
Collaborator
|
Will we need to add this in everytime we regenerate these files with a different gapic version ? |
Contributor
Author
AFAICT, yes, unless it gets fixed by gapic; the code generation allows configuring things like default timeouts and retry parameters for each rpc, but not this prefetching flag. I don't think regeneration happens very often, but if we have instructions on the procedure we'd want to include this hack with the instructions. |
Collaborator
|
I'll add a comment to the existing documentation and reference this PR. |
wcourtney
approved these changes
Feb 25, 2022
wcourtney
left a comment
wcourtney
left a comment
Collaborator
There was a problem hiding this comment.
Yikes that looks like a pain to find. Thanks for digging into this, Matt!
95-martin-orion
pushed a commit
to 95-martin-orion/Cirq
that referenced
this pull request
Mar 2, 2022
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefetching doesn't work because the service does not send any messages until after the user has sent at least one request. It seems prefetching was added in gapic 1.17.0 and broke some other streaming APIs such as pubsub (googleapis/python-api-core#25). This changes follows the official workaround, which is unfortunately pretty hacky (googleapis/python-api-core#30).
@wcourtney, @verult