Allow choice of subdimension in cirq.apply_unitary - #4910
Merged
Merged
Conversation
daxfohl
commented
Feb 2, 2022
daxfohl
changed the title
daxfohl
changed the title
daxfohl
changed the title
Contributor
|
Pinging reviewers - please reassign if necessary. |
dabacon
requested changes
May 16, 2022
dabacon
left a comment
dabacon
left a comment
Collaborator
There was a problem hiding this comment.
What do you mean by:
since it can't do arbitrary subdimensions that can't be represented as a slice
?
I guess the main use of this is for mismatched qid cases?
MichaelBroughton
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Fixes quantumlib#2862 by making the unitary subspace configurable. @Strilanc @dabacon do we want to make this explicit or does it just create extra confusion, especially since it can't do arbitrary subdimensions that can't be represented as a slice?
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
Fixes quantumlib#2862 by making the unitary subspace configurable. @Strilanc @dabacon do we want to make this explicit or does it just create extra confusion, especially since it can't do arbitrary subdimensions that can't be represented as a slice?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2862 by making the unitary subspace configurable.
@Strilanc @dabacon do we want to make this explicit or does it just create extra confusion, especially since it can't do arbitrary subdimensions that can't be represented as a slice?