Skip to content

bpo-40661: Fix segfault when parsing invalid input #20165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 4 commits into from
May 18, 2020
Merged

bpo-40661: Fix segfault when parsing invalid input #20165

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a1a9d28
bpo-40661: Fix segfault when parsing invalid input
lysnikolaou May 17, 2020
9ec03ba
Check for errors at the beginning of each rule as well
lysnikolaou May 17, 2020
b7be72c
Update Lib/test/test_peg_parser.py
gvanrossum May 18, 2020
7353b6c
Add test also to test_syntax
pablogsal May 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Lib/test/test_peg_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,6 +591,7 @@ def f(*a, b):
("f-string_single_closing_brace", "f'}'"),
("from_import_invalid", "from import import a"),
("from_import_trailing_comma", "from a import b,"),
("import_non_ascii_syntax_error", "import ä £"),

@pablogsal pablogsal May 18, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add this to test_syntax as well? This file will likely go away when we don't have two parsers to compare against anymore.

@pablogsal pablogsal May 18, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have pushed this myself in commit 7353b6c

# This test case checks error paths involving tokens with uninitialized
# values of col_offset and end_col_offset.
("invalid indentation",
Expand Down
Loading