Skip to content

gh-148989: _remote_debugging: Remove dead code, unnecessary gc state read #148990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 1 commit into from
Apr 25, 2026
+0 −13
Merged

gh-148989: _remote_debugging: Remove dead code, unnecessary gc state read #148990

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions Modules/_remote_debugging/threads.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,19 +314,6 @@ unwind_stack_for_thread(

long tid = GET_MEMBER(long, ts, unwinder->debug_offsets.thread_state.native_thread_id);

// Read GC collecting state from the interpreter (before any skip checks)
uintptr_t interp_addr = GET_MEMBER(uintptr_t, ts, unwinder->debug_offsets.thread_state.interp);

// Read the GC runtime state from the interpreter state
uintptr_t gc_addr = interp_addr + unwinder->debug_offsets.interpreter_state.gc;
char gc_state[SIZEOF_GC_RUNTIME_STATE];
Copy link
Copy Markdown
Contributor Author

@maurycy maurycy Apr 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SIZEOF_GC_RUNTIME_STATE has to stay:

cpython/Modules/_remote_debugging/debug_offsets_validation.h

Line 366 in 665b7df

PY_REMOTE_DEBUG_VALIDATE_READ_SECTION(gc, SIZEOF_GC_RUNTIME_STATE);

cpython/Modules/_remote_debugging/module.c

Lines 527 to 532 in 665b7df

uintptr_t gc_frame = 0;
if (self->gc) {
gc_frame = GET_MEMBER(uintptr_t, interp_state_buffer,
self->debug_offsets.interpreter_state.gc
+ self->debug_offsets.gc.frame);
}

if (_Py_RemoteDebug_PagedReadRemoteMemory(&unwinder->handle, gc_addr, unwinder->debug_offsets.gc.size, gc_state) < 0) {
set_exception_cause(unwinder, PyExc_RuntimeError, "Failed to read GC state");
goto error;
}
STATS_INC(unwinder, memory_reads);
STATS_ADD(unwinder, memory_bytes_read, unwinder->debug_offsets.gc.size);

// Calculate thread status using flags (always)
int status_flags = 0;

Expand Down
Loading