gh-115119: Removed bundled copy of the libmpdec#133964
Conversation
skirpichev
force-pushed
the
remove-bundled-mpdecimal/115119
branch
from
7cba56a to
9d6c9b5
Compare
AA-Turner
left a comment
AA-Turner
left a comment
There was a problem hiding this comment.
quick comments, haven't looked at build system changes
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
skirpichev
force-pushed
the
remove-bundled-mpdecimal/115119
branch
from
0a33f9f to
2ba6b8b
Compare
Co-authored-by: Zachary Ware <zachary.ware@gmail.com>
sethmlarson
left a comment
sethmlarson
left a comment
There was a problem hiding this comment.
Reviewed the changes to sbom.spdx.json and generate_sbom.py and those changes LGTM.
zware
left a comment
zware
left a comment
There was a problem hiding this comment.
Quite close, I think, just a few more cleanups.
| Previously, the :mod:`!_decimal` C extension underlying the :mod:`decimal` module | ||
| was built using an included copy of the libmpdec | ||
| library unless the build is configured ``--with-system-libmpdec``:: |
There was a problem hiding this comment.
Wouldn't hurt to fix the libffi section as well. Suggested wording here, though:
| Previously, the :mod:`!_decimal` C extension underlying the :mod:`decimal` module | |
| was built using an included copy of the libmpdec | |
| library unless the build is configured ``--with-system-libmpdec``:: | |
| The :mod:`!_decimal` C extension underlying the :mod:`decimal` module | |
| is linked to the libmpdec C library:: |
On the other hand, we could just leave this file alone for now and get someone more knowledgeable about such things to tell us what we should do in a separate issue :)
There was a problem hiding this comment.
Then lets keep this intact.
| # Disable forced inlining in debug builds, see GH-94847 | ||
| AS_VAR_IF( | ||
| [with_pydebug], [yes], | ||
| [AS_VAR_APPEND([LIBMPDEC_CFLAGS], [" -DTEST_COVERAGE"])]) |
There was a problem hiding this comment.
This is only relevant for building libmpdec itself, isn't it?
There is a usage of TEST_COVERAGE in Modules/_decimal/_decimal.c, but I don't see anything ever defining it for that module.
There was a problem hiding this comment.
There is a usage of TEST_COVERAGE in Modules/_decimal/_decimal.c, but I don't see anything ever defining it for that module.
It's defined there, no?
There was a problem hiding this comment.
Ok, sorry, my understanding of how LIBMPDEC_{CFLAGS,LDFLAGS} work was incorrect; this is fine.
There was a problem hiding this comment.
Given that this define used only in one place, we could replace it with Py_DEBUG in the code.
Co-authored-by: Zachary Ware <zachary.ware@gmail.com>
Co-authored-by: Zachary Ware <zachary.ware@gmail.com>
6 participants
libmpdecsources #115119📚 Documentation preview 📚: https://cpython-previews--133964.org.readthedocs.build/