Skip to content

gh-106368: Argument clinic tests: improve failure message when tests in ClinicExternalTests fail #107364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexWaygood merged 2 commits into from
Jul 27, 2023
Merged

gh-106368: Argument clinic tests: improve failure message when tests in ClinicExternalTests fail #107364

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8842c5e
Argument clinic tests: improve failure message when tests in `ClinicE…
AlexWaygood Jul 27, 2023
81ebc85
RIP itertools.chain: gone but not forgotten
AlexWaygood Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Lib/test/test_clinic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
from unittest import TestCase
import collections
import inspect
import itertools
Comment thread
AlexWaygood marked this conversation as resolved.
Outdated
import os.path
import subprocess
import sys
Expand Down Expand Up @@ -1386,7 +1387,7 @@ def _do_test(self, *args, expect_success=True):
) as proc:
proc.wait()
if expect_success and proc.returncode:
self.fail("".join(proc.stderr))
self.fail("".join(itertools.chain(proc.stdout, proc.stderr)))
Comment thread
AlexWaygood marked this conversation as resolved.
Outdated
stdout = proc.stdout.read()
stderr = proc.stderr.read()
# Clinic never writes to stderr.
Expand Down